-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token Validation Settings Page Display Error on OC 1.9.x latest preview version #15525
Comments
I've been looking for days, but I've finally located the problem 🤣 cc: @sebastienros @Skrypt @ns8482e The full reproduction step is as follows
(Please ignore the difference in the tenant name on my computer)
Then run the program and enable the 'OpenID Token Validation' module on tenant
I think it should be related to #15511 |
@hyzx86 thanks for providing the steps to reproduce the issue. @sebastienros I do not think this is an issue we should care about. Here we are faking a running tenant in the tenants.json file where that tenant should not exists. When we try to build the site for this fake tenant, it failed to create I am going to remove the |
The e problem now is that we have to make sure that all tenants are connected to the database properly, |
Yes. But this isn't a new behavior we introduced. It's been that way for a long time. At the end of the day, if you don't mess up or manually edit the core files, you won't end up in this corrupt state. |
In a multi-tenant scenario, if we expose a subtenant administrator to manage the tenant database, then if a user breaks the database, it will cause problems in other tenants' applications This problem only exists in version 1.9.x and works fine in 1.8.x |
Describe the bug
To Reproduce
Fist I need to clarify that , when I copy my site data to the OC source code project,then running this page without any problems,
I would like to know if I have made some breaking changes recently, which causes me to need to adjust some of my code?
I've checked this document to make sure my code has made all the adjustments.
https://github.com/OrchardCMS/OrchardCore/blob/main/src/docs/releases/1.9.0.md
My project is based on Nuget package of OC, everything was fine under 1.8 version, but after upgrading to 1.9, some strange phenomenon occurred.
First, there was a problem in the openid login process, when requesting tokens, the browser reported an error.
I tried to locate the problem, using the latest code of local OC package and copy the dll and pdb to my project,
then start my project (Ctrl + F5), and then go to the source code of OC and click Append to process.
When I opened the
Token Validation
menu, the debugger began to report an error.http://localhost:2919/salesportal/Admin/OrchardCore.OpenId/ValidationConfiguration/Index? admin=-571533867
At present, it seems that except for this page, other pages can be opened normally.
Expected behavior
The page should open normally
Screenshots
Warning session is empty, at line 56
The following is part of the log content
The text was updated successfully, but these errors were encountered: