User Registration Validation Lists Email Missing Error Twice

[SusanEnneking]

Describe the bug

Registration produces duplicate "Email is required" messages when the submit button is pressed without entering any information.

Orchard Core version

1.8.3

To Reproduce

Steps to reproduce the behavior:

1. The problem can be reproduced using Try Orchard Core
2. Choose the Agency Theme and enable Registration
3. Navigate to /Registration
4. Click submit without filling in any input and you'll see the error.

Looks like this problem has occurred in the past and was addressed with this ticket.

Expected behavior

When Email address is missing, the validation error should only show up once.

Logs and screenshots

[github-actions]

Thank you for submitting your first issue, awesome! 🚀 We're thrilled to receive your input. If you haven't completed the template yet, please take a moment to do so. This ensures that we fully understand your feature request or bug report. On what happens next, see the docs.

If you like Orchard Core, please star our repo and join our community channels.

[MikeAlhayek]

This issue was fixed in 2.0 via #16552

[gvkries]

This issue was fixed in 2.0 via #16552

Nope, that was a different issue.

I remember that I fixed this issue a long time ago, but it was re-introduced shortly afterwards by #11130 which I did not notice.

But now in 2.0 the whole login/registration has been changed to use shapes. I think that change fixes this issue as well. Or can you reproduce this in main?

[MikeAlhayek]

@gvkries the issue is fixed in main. Is there a reason you re-opened this issue?

[gvkries]

@gvkries the issue is fixed in main. Is there a reason you re-opened this issue?

Because I haven't had time to actually check if my statement above is correct...

[gvkries]

This issue has been fixed in 2.0, but by #15736.