Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Permissions from PermissionProviders classes #16766

Open
MikeAlhayek opened this issue Sep 19, 2024 · 2 comments · May be fixed by #16769
Open

Split Permissions from PermissionProviders classes #16766

MikeAlhayek opened this issue Sep 19, 2024 · 2 comments · May be fixed by #16769
Assignees
Milestone

Comments

@MikeAlhayek
Copy link
Member

Permission constants should be extracted into a dedicated or a constants class but should not be part of any permission provider.

Permission provider should live into the module where the Permission constants should be in the core project.

This if we need to check for the permission constant, we don't need to reference the module.

@MikeAlhayek MikeAlhayek added this to the 3.0 milestone Sep 19, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@hishamco
Copy link
Member

I think it will be better to add the permissions in OC.XXX.Abstractions instead this will be helpful for 3rd part modules, but I agree we could add them into OC.XXX.Core where the abstractions is not exist or for modules that have core package such as Search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants