Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataTestPrefixId usage is unintuitive #588

Open
mkarajohn opened this issue Mar 15, 2023 · 0 comments
Open

dataTestPrefixId usage is unintuitive #588

mkarajohn opened this issue Mar 15, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@mkarajohn
Copy link
Contributor

mkarajohn commented Mar 15, 2023 •
edited
Loading

Speaking with http://ictinus.herokuapp.com/?path=/docs/design-system-button--icon-button-sizes as a reference, the dataTestPrefixId prop does not indicate that a default value is used (which in truth it's button-)

Furthermore, even if dataTestPrefixId is passed a value, the final data-testid attribute will have the value <PREFIX>-button-<VALUE> which comes in contrast to the common expectation that the user-defined prefix would replace the default one (in this case <PREFIX> should replace button-)
@mkarajohn mkarajohn added the enhancement New feature or request label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkarajohn