Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site needs support for the new Addresses theme #95

Closed
4 of 5 tasks
Bonkles opened this issue Jul 15, 2024 · 5 comments · Fixed by #97
Closed
4 of 5 tasks

Site needs support for the new Addresses theme #95

Bonkles opened this issue Jul 15, 2024 · 5 comments · Fixed by #97
Assignees

Comments

@Bonkles
Copy link
Collaborator

Bonkles commented Jul 15, 2024

Description

There's a new theme we should be visualizing- addresses. There's a temporary URL that we can use for just getting the data up onto the site that @bdon provided:

https://protomaps.dev/~bdon/addresses.pmtiles

Of course this is a temp URL but we can use it for staging purposes / getting something built.

This task ask that we:

  • create an 'Addresses' layer at the top of the Z order (above everything else)
  • Style it with simple dots/circles/colors (nothing fancy)
  • Support selection like the other layers
  • Add theme selector support for addresses
  • Add inspector panel support for addresses (schema hasn't quite landed yet- find it in this PR)

What browser are you seeing the problem on? What version are you running?

Chrome v120

The OS you're using

MacOs 14

Steps to reproduce

n/a - just a feature we don't yet support.

GERS ID of the entity in question (if applicable)

n/a

The browser URL at the time you encountered the bug

n/a

@eti7075
Copy link
Collaborator

eti7075 commented Jul 16, 2024

Screenshot 2024-07-16 at 2 19 57 PM
This is the proposed styling for addresses. I used with a basic cyan to clearly be separate from other themes, and reused the point styling used in places for the geometry.

@eti7075
Copy link
Collaborator

eti7075 commented Jul 16, 2024

Subject to change: Size and color of the dots - where there is address data, there is much more than other themes, so we might want to consider a small point radius to reduce clutter, and the cyan is not set in stone, but currently does a good job of being very different from other theme colorings

@eti7075 eti7075 linked a pull request Jul 16, 2024 that will close this issue
@bdon
Copy link
Contributor

bdon commented Jul 17, 2024

We could parameterize ThemeTypeLayer to make the point radius for addresses smaller:

https://github.com/OvertureMaps/io-site/blob/main/site/src/Map.jsx#L84

@eti7075
Copy link
Collaborator

eti7075 commented Jul 17, 2024

Here is addresses at a radius of 5. I think it is a good balance between being a different size than other points, while still maintaining the definition that we want a point to have at lower zoom values.
Screenshot 2024-07-17 at 9 32 32 AM

@bdon
Copy link
Contributor

bdon commented Jul 17, 2024

Looks good to me! I will also prepare a PR to put labels on top, since it looks awkward with points covering labels right now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants