Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix failing checks #215

Merged
merged 1 commit into from
Mar 16, 2024
Merged

chore: fix failing checks #215

merged 1 commit into from
Mar 16, 2024

Conversation

P403n1x87
Copy link
Owner

No description provided.

@P403n1x87 P403n1x87 self-assigned this Mar 16, 2024
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.55%. Comparing base (0bbe368) to head (1a70b21).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #215      +/-   ##
==========================================
+ Coverage   68.16%   68.55%   +0.39%     
==========================================
  Files          27       27              
  Lines        2519     2519              
  Branches      774      774              
==========================================
+ Hits         1717     1727      +10     
+ Misses        465      460       -5     
+ Partials      337      332       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Austin Benchmarks

Running Austin benchmarks with Python 3.10.13

Benchmark Summary

Comparison of dev against 3.6.0.

The following scenarios show a statistically significant difference in performance between the two versions.

Sample Rate Saturation Error Rate Sampling Speed
Wall time [sampling interval: 1] 🟢 🟢 🟡 🟢
Wall time [sampling interval: 100] 🟡 🟡 🔴 🟡
CPU time [sampling interval: 100] 🟡 🟡 🔴 🟡
Full metrics [sampling interval: 1] 🟡 🟡 🔴 🟡
Full metrics [sampling interval: 10] 🟢 🟢 🔴 🟢
Full metrics [sampling interval: 100] 🟡 🟡 🟡 🟢
Multiprocess wall time [sampling interval: 10] 🟢 🟡 🔴 🟡

Benchmark Results

Wall time [sampling interval: 1]

Wall time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 192000 ± 4000 1 ± 0 3e-06 ± 4e-06 7.8 ± 0.4
dev 199000 ± 3000 0.99991 ± 5e-05 5e-06 ± 4e-06 7.1 ± 0.3
Wall time [sampling interval: 10]

Wall time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 58000 ± 9000 0.33 ± 0.06 1e-05 ± 1e-05 9.5 ± 0.5
dev 60000 ± 10000 0.35 ± 0.05 2e-05 ± 2e-05 9.3 ± 0.5
Wall time [sampling interval: 100]

Wall time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 12400 ± 200 0.0005 ± 0.0001 0 ± 0 9.1 ± 0.6
dev 12400 ± 200 0.0005 ± 0.0002 2e-05 ± 3e-05 9.0 ± 0.8
Wall time [sampling interval: 1000]

Wall time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 1850 ± 20 0 ± 0 0 ± 0 10.6 ± 0.7
dev 1860 ± 20 0 ± 0 0.0 ± 0.0001 10.4 ± 0.7
CPU time [sampling interval: 1]

CPU time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 61000 ± 3000 1 ± 0 2e-05 ± 1e-05 12.9 ± 0.6
dev 62000 ± 3000 1 ± 0 1.1e-05 ± 7e-06 12.7 ± 0.7
CPU time [sampling interval: 10]

CPU time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 57000 ± 3000 0.65 ± 0.05 1.5e-05 ± 8e-06 13.5 ± 0.5
dev 57000 ± 3000 0.66 ± 0.07 2.1e-05 ± 9e-06 13.3 ± 0.7
CPU time [sampling interval: 100]

CPU time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6357 ± 6 0.0006 ± 0.0002 2e-05 ± 4e-05 17.5 ± 0.7
dev 6350 ± 20 0.0007 ± 0.0002 8e-05 ± 7e-05 17 ± 1
CPU time [sampling interval: 1000]

CPU time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 947 ± 1 0 ± 0 0 ± 0 19 ± 1
dev 947 ± 1 0 ± 0 0.0001 ± 0.0004 20 ± 2
RSA keygen [sampling interval: 1]

RSA keygen [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 62000 ± 3000 1 ± 0 0.0001 ± 0.0001 15.4 ± 0.8
dev 62000 ± 4000 1 ± 0 0.00013 ± 6e-05 15.5 ± 1.0
RSA keygen [sampling interval: 10]

RSA keygen [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 60000 ± 4000 0.995 ± 0.004 0.0002 ± 0.0002 16 ± 1
dev 63000 ± 3000 0.9978 ± 0.001 0.0001 ± 0.0001 15.3 ± 0.8
RSA keygen [sampling interval: 100]

RSA keygen [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6350 ± 30 0.0003 ± 0.0005 0.0005 ± 0.0006 20 ± 3
dev 6350 ± 10 0.001 ± 0.001 0.0007 ± 0.0008 20 ± 2
RSA keygen [sampling interval: 1000]

RSA keygen [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 945.3 ± 0.7 0 ± 0 0.0002 ± 0.0006 20 ± 3
dev 945.2 ± 0.7 0 ± 0 0.0 ± 0.001 21 ± 4
Full metrics [sampling interval: 1]

Full metrics [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 74000 ± 2000 1 ± 0 8e-06 ± 8e-06 19.8 ± 0.6
dev 76000 ± 3000 1 ± 0 2e-05 ± 1e-05 19.8 ± 0.6
Full metrics [sampling interval: 10]

Full metrics [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 75000 ± 1000 0.91 ± 0.03 1e-05 ± 1e-05 19.9 ± 0.6
dev 77000 ± 2000 0.87 ± 0.03 2e-05 ± 9e-06 19.1 ± 0.3
Full metrics [sampling interval: 100]

Full metrics [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 12500 ± 200 0.001 ± 0.0001 1e-05 ± 2e-05 24.9 ± 0.7
dev 12300 ± 200 0.0011 ± 0.0003 4e-05 ± 4e-05 23.9 ± 1.0
Full metrics [sampling interval: 1000]

Full metrics [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 1870 ± 20 0 ± 0 0.0 ± 0.0001 27 ± 2
dev 1860 ± 30 0 ± 0 0.0001 ± 0.0002 27 ± 2
Multiprocess wall time [sampling interval: 1]

Multiprocess wall time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6800 ± 800 1 ± 0 7e-05 ± 4e-05 133 ± 5
dev 7300 ± 200 1 ± 0 0.0001 ± 3e-05 132 ± 4
Multiprocess wall time [sampling interval: 10]

Multiprocess wall time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6700 ± 900 0.9985 ± 0.0006 6e-05 ± 4e-05 130 ± 20
dev 7400 ± 400 0.999 ± 0.001 0.00012 ± 6e-05 130 ± 6
Multiprocess wall time [sampling interval: 100]

Multiprocess wall time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6300 ± 1000 0.02 ± 0.003 3e-05 ± 3e-05 130 ± 10
dev 7000 ± 200 0.02 ± 0.003 6e-05 ± 3e-05 136 ± 3
Multiprocess wall time [sampling interval: 1000]

Multiprocess wall time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.6.0 6300 ± 600 0.0012 ± 0.0003 2e-05 ± 2e-05 40 ± 2
dev 6640 ± 90 0.0012 ± 0.0002 1e-05 ± 1e-05 40 ± 2

@P403n1x87 P403n1x87 merged commit ebfd9fd into devel Mar 16, 2024
38 of 42 checks passed
@P403n1x87 P403n1x87 deleted the chore/fix-checks branch March 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant