Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekday range to sunday edge case #282

Closed
sky0hunter opened this issue Mar 14, 2023 · 3 comments · Fixed by #283
Closed

Weekday range to sunday edge case #282

sky0hunter opened this issue Mar 14, 2023 · 3 comments · Fixed by #283
Labels
released on @next released

Comments

@sky0hunter
Copy link
Contributor

Heyho,

there is a little bug when using a range for weekdays which includes sunday as '7', due to the replacement with '0'.

I.e.: 5 10 * * 6-7 will throw Failed to parse 6-7: Invalid range (start: 6, end: 0).
@P4sca1
Copy link
Owner

P4sca1 commented Mar 14, 2023

Thank you for raising this. I'm going to have a look at this, once I get some spare time.

@sky0hunter sky0hunter mentioned this issue Mar 14, 2023
Merged
@P4sca1
Copy link
Owner

P4sca1 commented Mar 30, 2023

🎉 This issue has been resolved in version 4.0.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@P4sca1
Copy link
Owner

P4sca1 commented Mar 30, 2023

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@P4sca1 P4sca1 closed this as completed Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly parse weekday ranges that include sunday sky0hunter/cron-schedule
2 participants
@sky0hunter @P4sca1