Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-flake unit tests failing due to WebGL context loss #48

Closed
jimbojw opened this issue Sep 1, 2022 · 0 comments
Closed

De-flake unit tests failing due to WebGL context loss #48

jimbojw opened this issue Sep 1, 2022 · 0 comments

Comments

@jimbojw
Copy link
Collaborator

jimbojw commented Sep 1, 2022

Browsers can only support a limited numbers of concurrent WebGL contexts. When the limit is exceeded, older contexts are dropped. This can cause errors and test failures.

Megaplot is designed to be used for big visualizations that take up a lot of screen space. In a production environment, exceeding the context limit is less likely. But the karma unit tests create many contexts to exercise various features and are starting to become flakey.

Task: De-flake the karma unit tests so that they succeed even if contexts are lost. This may require somehow forcing tests to execute sequentially. Karma appears to somehow interleave some of the code under test.

This effort may be aided by implementing an explicit Scene destroy() method as described in #47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant