Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert GeometricZoom formula to original, set default to 1 #82

Open
jimbojw opened this issue Oct 21, 2022 · 0 comments
Open

Revert GeometricZoom formula to original, set default to 1 #82

jimbojw opened this issue Oct 21, 2022 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@jimbojw
Copy link
Collaborator

jimbojw commented Oct 21, 2022

Currently, the GeometricZoom attribute, like all Sprite attributes, defaults to zero. To make this work, the formula used in the shader is this:

currentSizeWorld * exp(log(scale) * (1. - currentGeometricZoom))

Instead, the formula should match Benjamin Schmidt's original implementation:

currentSizeWorld * exp(log(scale) * currentGeometricZoom)

To do this, the GeometricZoom attribute needs to default to a value of 1, rather than 0. See #81

@jimbojw jimbojw added this to the V0.2.0 milestone Mar 14, 2023
@jimbojw jimbojw added the bug Something isn't working label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant