Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up #369 - Squiz.Arrays.ArrayDeclaration for static #379

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

michalbundyra
Copy link
Contributor

@michalbundyra michalbundyra commented Mar 4, 2024

Description

Follow-up #369 - per @jrfnl - see: #369 (comment)

Suggested changelog entry

Related issues/external references

Fixes #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

@jrfnl
Copy link
Member

jrfnl commented Mar 13, 2024

@michalbundyra FYI: Sorry, I haven't managed to get round to this and won't be able to get to it this week either (conference). Hoping to sort it out next week and tag the release soon after.

@jrfnl jrfnl added this to the 3.9.1 milestone Mar 13, 2024
@michalbundyra
Copy link
Contributor Author

@jrfnl no worries, there is no any rush here. Enjoy the conference!

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalbundyra Sorry it took me a while to get to this, but I've reviewed the patch now and ran some additional tests with it and I'm going to accept it as-is.

Thank you for the patch and for your patience!

I'll rebase this and will merge it after the build has passed.

@jrfnl jrfnl enabled auto-merge March 31, 2024 17:11
@jrfnl jrfnl merged commit 218d2a5 into PHPCSStandards:master Mar 31, 2024
38 checks passed
@michalbundyra michalbundyra deleted the fix/followup-369 branch March 31, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants