Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 Processing for PRs Hangs #1725

Closed
oleibman opened this issue Nov 22, 2020 · 1 comment
Closed

PHP8 Processing for PRs Hangs #1725

oleibman opened this issue Nov 22, 2020 · 1 comment

Comments

@oleibman
Copy link
Collaborator

This is:

- [x] a bug report
- [ ] a feature request
- [x] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

PHP8 tests should run to completion.
They do so on my local machine.
For PR #1721, PHP8 tests ran to completion as recently as Nov. 19. Updates today all succeeded for all other tests,
but failed to complete PHP8 tests. In an attempt to figure out why, I opened PR #1724. That PR changes no code or tests;
it is merely a documentation update. Nevertheless, it hangs some time after test 5368 of 6602, which seems to
indicate that the problem is with the PHP8 setup, or a recent change.

What is the current behavior?

PHP8 tests hang at around 81% of the way through, test 5429 of 6621 for PR1721, and 5368 of 6602 for PR1724.

What are the steps to reproduce?

It appears that any PR should trigger the problem.

Please provide a Minimal, Complete, and Verifiable example of code that exhibits the issue without relying on an external Excel file or a web server:

Which versions of PhpSpreadsheet and PHP are affected?

Current version of PhpSpreadsheet, PHP8.0 as implemented in PR environment.

@oleibman
Copy link
Collaborator Author

PR #1733 passed all tests today; two PR's between my issue and that one had also failed the PHP8 step. With that in mind, I re-pushed 1724 and 1721 with minor textual corrections, both of which also passed. So I can close this issue, and will also close 1724; and wait for 1721 to be merged or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant