async stdin/stdout errors (compiling nimlsp on Windows)

[veksha]

Hello. I get exception at runtime (on Windows 11 x64). following lines seem to be the culprit:

import asyncfile, asyncdispatch
var
  ins = newAsyncFile(stdin.getOsFileHandle().AsyncFD)
  outs = newAsyncFile(stdout.getOsFileHandle().AsyncFD)

exception

D:\Programm\Nim\nim-inject\test.nim(8) test
D:\Programm\Nim\Nim-devel\lib\pure\asyncfile.nim(90) newAsyncFile
D:\Programm\Nim\Nim-devel\lib\pure\asyncdispatch.nim(341) register
D:\Programm\Nim\Nim-devel\lib\pure\includes\oserr.nim(94) raiseOSError
Error: unhandled exception: The parameter is incorrect
[OSError]

PMunch's comment on nim forum:

I think the error here is that the standard input on Windows isn't capable of async reads, and somehow the devel version of Nim detects this (although in the async runtime code, not as a limited type on the getOsFileHandle procedure). When you post this on GitHub please make sure to tag @haxscramper as well, they're the one who implemented the async logic.

@haxscramper

[PMunch]

Oh sorry, it wasn't @haxscramper, it was @bung87 who did the async stuff for NimLSP..

[bung87]

get it , for now fallback to v0.3.2

[PMunch]

@bung87, did you have a chance to look into this further? It's not great that Windows users can't run the latest version.

[bung87]

have not found any handy lib to archive this? do you have any recommend lib?

[PMunch]

Unfortunately it appears that standard input on Windows is not possible to read asynchronously. The only way to do this that I'm aware of is to spawn a second thread to read input.

[bung87]

copy author original post from nim forum here.

D:\Programm\Nim\nim-inject\test.nim(8) test
D:\Programm\Nim\Nim-devel\lib\pure\asyncfile.nim(90) newAsyncFile
D:\Programm\Nim\Nim-devel\lib\pure\asyncdispatch.nim(341) register
D:\Programm\Nim\Nim-devel\lib\pure\includes\oserr.nim(94) raiseOSError
Error: unhandled exception: The parameter is incorrect

I have the latest Nim devel version. 1.7.1 dc4cc2dca53e3772efb3654a4ddbbe8350d1db43

PS: it actually compiles, but when you run - you got error.

[veksha]

@bung87 any ideas how to fix this?
found this asynctools/asyncproc.nim
can this info help you?

[PMunch]

I think the best way to handle this for now is to make it use async on Linux and the old synchronous behaviour on Windows. @bung87 would you be able to implement this?

[bung87]

am able to do this , I'll first make sure the error whether or not cause by async logic, the error message is coming from windows os error, as @PMunch said there is only one commen on nim repo contains "The parameter is incorrect' in compiler file.

[bung87]

@bung87 any ideas how to fix this?
found this asynctools/asyncproc.nim
can this info help you?

I've search a lot repos , found no perfect lib match the requires.

[bung87]

yeah, windows is not support when fd.Handle is std io

    if createIoCompletionPort(fd.Handle, p.ioPort,
                              cast[CompletionKey](fd), 1) == 0:
      raiseOSError(osLastError())
    p.handles.incl(fd)

[bung87]

https://github.com/bung87/nimlsp/actions/runs/2359268373 I try to use mutisync but encounter various kind of error @PMunch @veksha have time to check ?

[veksha]

@bung87 have you tried -d:asyncBackend=none as stated here:
https://nim-lang.org/docs/asyncdispatch.html#multiple-async-backend-support
if it will work somehow - it will be very small fix for our problem here. code must not be so overcomplicated. in my humble opinion. :)

[bung87]

@bung87 have you tried -d:asyncBackend=none as stated here:
https://nim-lang.org/docs/asyncdispatch.html#multiple-async-backend-support
if it will work somehow - it will be very small fix for our problem here. code must not be so overcomplicated. in my humble opinion. :)

it does not work on my MBP I still get Exception message: index out of bounds, the container is empty when I run nimble test , weird ci report another kind error.

[bung87]

error now is consistent , see https://github.com/bung87/nimlsp/runs/6528943601?check_suite_focus=true

[bung87]

in the end I change to stream api.