Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 static site deploys do not roll back on stack failures #210

Open
farski opened this issue Mar 30, 2018 · 0 comments
Open

S3 static site deploys do not roll back on stack failures #210

farski opened this issue Mar 30, 2018 · 0 comments
Labels

Comments

@farski
Copy link
Member

farski commented Mar 30, 2018

In cases where an S3 static site deploy (via the custom resource) succeeds as part of a CloudFormation stack update that otherwise fails, currently the resource may not correctly handle the rollback.

(I'm actually not sure about this. CloudFormation may just send another Update event with the old parameters to trigger the rollback, in which case this should pretty much take care of itself (though perhaps #209 is more impactful in this case, because there would be new, unreleased files remaining in S3)

@farski farski added the low label Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant