Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed importer allows invalid images #540

Open
cavis opened this issue Dec 12, 2019 · 1 comment
Open

Feed importer allows invalid images #540

cavis opened this issue Dec 12, 2019 · 1 comment
Labels

Comments

@cavis
Copy link
Member

cavis commented Dec 12, 2019

Import a feed with an invalid top-level itunes image (< 1400x1400, for example)

What happens:

  • Import succeeds, kicks off an async cms-image-lambda
  • Image callback worker starts, updates CMS db, announces to feeder
  • Feeder story/episode update worker starts, gets image, checks dimensions itself
  • Feeder fails to update episode due to validation error, rejects change

I guess I'm not quite clear what to expect in this scenario, since there's an async image worker involved. But it would be nice if we showed this invalid image error to the user somewhere - either in the import tab or on the series basic-info. Just a warning that "hey, that image on your previous feed should be > 1400x1400".

@cavis cavis added the medium label Dec 16, 2019
@cavis
Copy link
Member Author

cavis commented Dec 16, 2019

Question: could we call Porter synchronously, just to check the image dimensions?

Or maybe we just wait until we're actively resizing (upsizing?) images to meet the feed requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant