Fix delegated delivery: Dont update episodes for mixed feed release #1097
Conversation
| @@ -7,6 +7,9 @@ class Api | |||
| DEFAULT_BATCH_SIZE = 5 | |||
| DEFAULT_WRITE_BATCH_SIZE = 1 | |||
|
|
|||
| NOT_FOUND = 404 | |||
| CONFLICT = 409 | |||
There was a problem hiding this comment.
409, bane of my existence.
great to have this handling for it now!
| @@ -171,8 +174,11 @@ def check_row(row_operation) | |||
| true | |||
| end | |||
|
|
|||
| def ok_code(resp, ignore_not_found: false) | |||
| return true if ignore_not_found && resp.code.to_i == 404 | |||
| def ok_code(resp, ignore_errors: []) | |||
There was a problem hiding this comment.
and the reason to pass in the errors to ignore is so we only ignore 409 on some requests - esp updates?
It looks like they are not ignored for when querying/getting data, and are ignored on updates - I wonder if we could even get a 409 for a query? anyway, this make sense, no reason to change it.
There was a problem hiding this comment.
Hrm, So this may not be quite right.
Because we're proxying requests via the api bridge, this "ok_code" is examining the wrapper's response code, not the DD API responses.
The actual api responses are probed and filtered here https://github.com/PRX/feeder.prx.org/pull/1097/files#diff-3ee82c0e582e70e00c46671634fbf13b219bd4297018576f21fb6f1d4e2133fbR233
Closes #1080