-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't find the steady-state with DEP tax function #26
Comments
@nikhilwoodruff I had the same issue. I think what one needs to do is estimate the tax functions and plot them to see how they look. I would be best to start simple - e.g., with GS functions before DEP functions, with non-age-specific before age-specific. I have not done this yet. |
@jdebacker @rickecon could you share code for plotting tax functions? e.g. from pslmodels.github.io/OG-USA/content/calibration/tax_functions: |
@nikhilwoodruff I like the 2D plots are you reference. I'd recommend using the Here's an example plotting non-age-specific DEP functions:
3D plots are also available in |
Here's updated code that I ran from my OG-UK directory (had a typo above):
Kind of an odd pattern in the raw data (the blue dots), but this was with the toy dataset. Haven't run with the full FRS yet. If you have, I'd love to see what it looks like. |
Thanks for this @jdebacker - I'm running into some difficulties getting the plot to work, but in the meantime in case it's useful, here's what the ETR by market income scatter plot looks like (which should form the backdrop to that first chart type for the UK, and I used the outputs of |
@nikhilwoodruff Those ETRs look a lot better! Let me know if I can help with your issues getting the tax functions to plot. Can get on a Zoom if helpful. |
Sorry I've just seen this @jdebacker - here's my recent progress ahead of our meeting later:
I've also now finished a PR to openfisca-uk which cuts down the simulation time by about 70% so on my end it's a lot faster to debug the OG-USA runs now |
@nikhilwoodruff The micro data is looking excellent. It looks like you are plotting linear tax functions. It seems like DEP should be able to fit these data reasonably well, but wow, those negative ETRs are huge, so that could be tricky (if not to fit the functions, then to solve the model -- will want to set |
@jdebacker thanks for the ideas from our meeting yesterday- I just tried removing the guess overrides and also the OG-UK default parameters from the parametrization, and the steady-state solved. Will update when the TPI finishes to see what it looks like. |
OK, so here's the results of OG-UK without
|
Here are the plots (some look a bit weird to me, but I don't fully understand everything here): |
And finally, here's the full output |
@nikhilwoodruff That's great - thanks for testing this and sharing the update. |
@nikhilwoodruff I was trying to replicate what you did and was having some issue. I removed and reinstalled the environment. Now I'm getting the following error (which I noticed on a recent PR by @MaxGhenis):
This looks related to the OpenFisca-UK data -- can you advise on the work around? |
@jdebacker @jpycroft @rickecon @MaxGhenis
Hi all,
So far I can run the entire model on a reform, but the default tax function estimation is
linear
. I'm guessing this is probably not ideal, but when I've changed it to DEP, the solver can't find the steady-state, even varying the initial guess forr
(I've tried 0.02, 0.04, 0.05, and 0.09). Is wondered whether this is just inevitable with the inclusion of benefit MTRs, or if there was any way around it?The text was updated successfully, but these errors were encountered: