Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recordio doc #248

Merged
merged 6 commits into from
Jul 26, 2017
Merged

add recordio doc #248

merged 6 commits into from
Jul 26, 2017

Conversation

Yancey1989
Copy link
Collaborator

Fixed #247

```python
import paddle.v2.dataset as dataset
dataset.convert(output_path = "./dataset",
reader = dataset.uci_housing.train(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用户可能不理解reader的意思,或者需要再去看dataset.uci_housing.train(),是否直接把例子贴到这里?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with a link to reader.

Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment.

gongweibao
gongweibao previously approved these changes Jul 26, 2017
Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gongweibao
gongweibao previously approved these changes Jul 26, 2017
Copy link
Collaborator

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

doc/usage_cn.md Outdated
@@ -68,6 +68,47 @@ scp -r my_training_data_dir/ user@tunnel-server:/mnt/hdfs_mulan/idl/idl-dl/mydir

在训练任务提交后,每个训练节点会把HDFS挂载在`/pfs/[datacenter_name]/home/[username]/`目录下这样训练程序即可使用这个路径读取训练数据并开始训练。

### 使用[RecordIO](https://github.com/PaddlePaddle/recordio)对训练数据进行预处理
用户可以在本地将数据预先处理为RecordIO的格式,再上传至集群进行训练。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用户可以=>用户需要

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

doc/usage_cn.md Outdated
def cluster_creator(filename):
import recordio
def reader():
r = recordio.reader("./dataset/uci_housing_train*")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有master的reader是需要在reader端dispatch文件的。这个例子还是按照dispatch的方法吧,master功能稳定之后再更新。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks.

Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yancey1989 Yancey1989 merged commit 98d0abb into PaddlePaddle:develop Jul 26, 2017
@Yancey1989 Yancey1989 deleted the recordio_doc branch July 26, 2017 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants