Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some important feedforward models to be supported at first stage #24

Closed
7 tasks done
kuke opened this issue Apr 14, 2018 · 5 comments
Closed
7 tasks done

Some important feedforward models to be supported at first stage #24

kuke opened this issue Apr 14, 2018 · 5 comments
Assignees

Comments

@kuke
Copy link

kuke commented Apr 14, 2018

We are going to support the conversion of models as follows at first stage. They all can be found in our models bank, some maybe only need to be verified after #19 merged, and some lack of necessary operators.

Even all the models above are supported, only a small subset of operators are used and verified. So for the rest operators, we may need another task:

Hints:

  • Choose one task every time and assign yourself when you are really ready for working on it;
  • Please append the model to the supported models section in README like Support conversion of recognize_digits models #19 after its conversion being validated.
@pkuyym
Copy link
Collaborator

pkuyym commented Apr 15, 2018

@kuke I think we can collect all the ops needed to be converted required by the listed models.
It's better to do Design the unit test framework to test every operator's conversion first and we can implement converter for fluid ops parallel. When all operator converter finished, I think it would be easy to validate the models.

@sidgoyal78
Copy link
Collaborator

Yeah, I agree with @pkuyym . I think it might be better to do design the unit test framework for a variety of operators.

@kuke
Copy link
Author

kuke commented Apr 17, 2018

I also agree with that unit test is very important, so I assign it to myself. But if you are interested in verifying the correctness of models' conversion, you can work on one now. From my experience, a runnable model will help you test the related operator's conversion and the unit test is not necessary.

@varunarora
Copy link
Collaborator

I'll take READMEs/installation, etc. Thanks @kuke and @pkuyym for your work on the models.

@kuke
Copy link
Author

kuke commented Apr 24, 2018

@varunarora Great! It is the time to have a friendly README and installation. I am going to continue to work on models' conversion. I think rest of us can pick up a model or general operators' conversion. You see we have a lot of operators waiting to be implemented the conversion.

Zeref996 pushed a commit to Zeref996/Paddle2ONNX that referenced this issue Aug 24, 2021
demo commit for adding inference testing case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants