Merge pull request #396 from PagerDuty/issue_389-0

Fix some mismatches between REST API and struct definitions

change_events.go

@@ -15,23 +15,23 @@ const changeEventPath = "/v2/change/enqueue"
 type ChangeEvent struct {
 	RoutingKey string             `json:"routing_key"`
 	Payload    ChangeEventPayload `json:"payload"`
-	Links      []ChangeEventLink  `json:"links"`
+	Links      []ChangeEventLink  `json:"links,omitempty"`
 }
 
 // ChangeEventPayload ChangeEvent ChangeEventPayload
 // https://developer.pagerduty.com/docs/events-api-v2/send-change-events/#example-request-payload
 type ChangeEventPayload struct {
-	Source        string                 `json:"source"`
 	Summary       string                 `json:"summary"`
-	Timestamp     string                 `json:"timestamp"`
-	CustomDetails map[string]interface{} `json:"custom_details"`
+	Source        string                 `json:"source,omitempty"`
+	Timestamp     string                 `json:"timestamp,omitempty"`
+	CustomDetails map[string]interface{} `json:"custom_details,omitempty"`
 }
 
 // ChangeEventLink represents a single link in a ChangeEvent
 // https://developer.pagerduty.com/docs/events-api-v2/send-change-events/#the-links-property
 type ChangeEventLink struct {
 	Href string `json:"href"`
-	Text string `json:"text"`
+	Text string `json:"text,omitempty"`
 }
 
 // ChangeEventResponse is the json response body for an event

change_events_test.go

@@ -7,8 +7,8 @@ import (
 )
 
 const (
-	expectedChangeCreatePayload = `{"routing_key":"a0000000aa0000a0a000aa0a0a0aa000","payload":{"source":"Test runner",` +
-		`"summary":"Summary can't be blank","timestamp":"2020-10-19T03:06:16.318Z",` +
+	expectedChangeCreatePayload = `{"routing_key":"a0000000aa0000a0a000aa0a0a0aa000","payload":{"summary":"Summary can't be blank",` +
+		`"source":"Test runner","timestamp":"2020-10-19T03:06:16.318Z",` +
 		`"custom_details":{"DetailKey1":"DetailValue1","DetailKey2":"DetailValue2"}},` +
 		`"links":[{"href":"https://acme.pagerduty.dev/build/2","text":"View more details in Acme!"},` +
 		`{"href":"https://acme2.pagerduty.dev/build/2","text":"View more details in Acme2!"}]}`

escalation_policy.go

@@ -28,7 +28,6 @@ type EscalationPolicy struct {
 	NumLoops        uint             `json:"num_loops,omitempty"`
 	Teams           []APIReference   `json:"teams"`
 	Description     string           `json:"description,omitempty"`
-	RepeatEnabled   bool             `json:"repeat_enabled,omitempty"`
 }
 
 // ListEscalationPoliciesResponse is the data structure returned from calling the ListEscalationPolicies API endpoint.