Allowing custom API endpoint in NewClient config

[alibasim86]

Hi,

Can we allow API Endpoint customization during client creation to allow the run from an air gapped environment where calls are made via an API gateway.

go-pagerduty/client.go

Line 98 in 44f00b5

func NewClient(authToken string) *Client {

Thanks
Ali

[stmcallister]

Hi @alibasim86! That's an interesting thought. While we think about ways we could address this, does your API gateway support a proxy mode? We do pick up environment proxy settings if you have HTTP_PROXY or HTTPS_PROXY.

[alibasim86]

Hi, even if the API gateway supports its the system internally that is using the go-pagerduty will be pointing to a custom URL (that's the API gateway) to talk to PagerDuty public API endpoints for both API and events.
ie:
api.pagerduty.com might be vip.mydomain.com/api
events.pagerduty.com might be vip.mydomain.com/events

Thanks
Ali

[stmcallister]

Would a function like this do the trick?

func NewClientWithAPIEndpoint(authToken, apiEndpoint string) *Client {
	return &Client{
		authToken:   authToken,
		apiEndpoint: apiEndpoint,
		authType:    apiToken,
		HTTPClient:  defaultHTTPClient,
	}
}

[alibasim86]

yep, That would do it. Thank you

[stmcallister]

So, we went with a little bit different of an approach. The way you'll set a custom APIEndpoint will look something like this:

client := NewClient("SOME_TOKEN", WithAPIEndpoint("https://mypdapi.com"))

[stmcallister]

Please comment, or post another issue, if you have further trouble with this.