Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For Change Events #246

Merged
merged 5 commits into from
Oct 21, 2020
Merged

Add Support For Change Events #246

merged 5 commits into from
Oct 21, 2020

Conversation

Sjeanpierre
Copy link
Contributor

This PR implements the newly released Change Events feature. PR #241 seems to have taken a better approach on dealing with V2 Event endpoints in general, so if we can get some consensus on that approach I'd be more than happy to refactor that bit of my implementation.

@joelcrocker
Copy link
Member

👍 for the approach for dealing with events API endpoints from #241.

@Sjeanpierre
Copy link
Contributor Author

Refactored to match the style from PR #241 should be good for review now @stmcallister

Copy link
Member

@joelcrocker joelcrocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great commenting and thanks for adding tests!

@stmcallister stmcallister merged commit 4cd79a4 into master Oct 21, 2020
@Sjeanpierre Sjeanpierre deleted the Add_Change_events branch October 21, 2020 02:06
@theckman theckman added this to the v1.4.0 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants