Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query params on tags #329

Merged
merged 1 commit into from
May 13, 2021
Merged

Conversation

jfmyers9
Copy link
Contributor

At the moment, this method is missing the ? which results in a 404 when providing query parameters.

Copy link
Collaborator

@theckman theckman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find; this also made me realize there is another case of this elsewhere that I will raise a PR to go with this one into v1.4.1.

@theckman theckman added this to the v1.4.1 milestone May 11, 2021
theckman added a commit that referenced this pull request May 11, 2021
When reviewing #329, I found that `ListBusinessServicesPaginated` and by proxy
`ListBusinessServices`, were not properly encoding their URL parameters,
effectively breaking pagination due to the missing ? before the values.

This adds the missing ? to the URL.
@theckman theckman merged commit 4ee8f43 into PagerDuty:master May 13, 2021
@theckman
Copy link
Collaborator

@jfmyers9 Thanks again for this PR! Just released v1.4.1 which includes this fix.

@jfmyers9 jfmyers9 deleted the fix-query-params-tags branch February 14, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants