Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with API calls which return errors as a string #376

Closed
wants to merge 1 commit into from

Conversation

tstromberg
Copy link

With the intent of fixing #339

@tstromberg tstromberg marked this pull request as draft November 5, 2021 00:00
@theckman
Copy link
Collaborator

@tstromberg thank you for taking the time to raise this Work In Progress PR. I took an initial look at it, but saw you had marked it as not being ready for review. This was something I did want to solve, in a slightly different way, so I raised #382.

We've gone with that approach (backported via #386) and have released v1.4.3 which fixes #339. I'm going to close this PR at this time.

Thanks again!

@theckman theckman closed this Nov 14, 2021
@tstromberg
Copy link
Author

Excellent. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants