Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting in the QodeAssist codebase #31

Open
SidneyCogdill opened this issue Nov 11, 2024 · 1 comment
Open

Code formatting in the QodeAssist codebase #31

SidneyCogdill opened this issue Nov 11, 2024 · 1 comment

Comments

@SidneyCogdill
Copy link
Contributor

Qt Creator comes with multiple code formatting tool integrations bundled, including clang-format for C/C++, qmlformat for QML, cmake-format for CMake files.

If I leave the "auto formatting on save" options enabled while editing QodeAssist sources, then the formatting tools will kick in and re-edit the whole file, the diff on the submitted patches will be full of re-formatting noises instead of highlighting the relevant changes.

Therefore it would be helpful if the codebase decides to explicitly opt into code formatting tools and provide a customized .qmlformat.ini and .clang-format in the project directory, so that the automatic formatting tools can respect the project's code formatting style.

Note that for cmake-format it doesn't seem to have the concept of a project-scope configuration file and have to manually pass the config file path as the command line option.

@Palm1r
Copy link
Owner

Palm1r commented Nov 11, 2024

Thank you for good idea, I agree, will add soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants