From e2d2cd6e86547d6c4a493b350b1cb1322d499233 Mon Sep 17 00:00:00 2001 From: "dennis.ludwig" Date: Wed, 30 Jun 2021 16:40:51 +0200 Subject: [PATCH] Set default of PUBLIC_URL to /build to align with createReactApp build folder --- .env | 2 +- README.md | 5 ++--- src/components/PageHelp/PageHelp.tsx | 6 +++--- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/.env b/.env index 0bcc8871..32dff736 100644 --- a/.env +++ b/.env @@ -1,2 +1,2 @@ REACT_APP_RADAR_NAME=AOE Technology Radar -PUBLIC_URL=/techradar +PUBLIC_URL=/build diff --git a/README.md b/README.md index f212f889..4dd6b3ed 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,6 @@ The AOE Tech radar is deployed here: https://www.aoe.com/techradar/index.html ## Usage for your own radar? The generator is free to use under Open Source License - in fact there are already some other Radars published based on our Radar and there are also Contributions back. -(There is a list of planned features below in case someone wants to contribute :-) However, please be aware: @@ -22,7 +21,7 @@ You can customize the following parts of the tech radar. Set the environment variable `REACT_APP_RADAR_NAME`. The default is "AOE Technology Radar". ### Host the application under a sub path -To host the application under a sub path, set the environment variable `PUBLIC_URL`, e.g. "/techradar". The default is "/techradar". +To host the application under a sub path, set the environment variable `PUBLIC_URL`, e.g. "/techradar". The default is "/build". ### Change the favicon To change the favicon, create a public folder in your application and put your favicon.ico in it. @@ -58,7 +57,7 @@ Serve python3 -m http.server 8080 ``` -Then open here: http://localhost:8080*PUBLIC_URL* +Then open here: http://localhost:8080/build ### Run a prepared static version To have a better SEO ranking, you can generate a html file for every page. diff --git a/src/components/PageHelp/PageHelp.tsx b/src/components/PageHelp/PageHelp.tsx index a0030e57..0c259944 100644 --- a/src/components/PageHelp/PageHelp.tsx +++ b/src/components/PageHelp/PageHelp.tsx @@ -68,8 +68,8 @@ export default function PageHelp({ more-informed and better-aligned decisions.

- We also hope that developers outside of AOE find the informations in - our technologie overview inspirational. + We also hope that developers outside of AOE find the information in + our technology overview inspirational.

We group or categorize the items in 4 quadrants - (sometimes, when @@ -81,7 +81,7 @@ export default function PageHelp({ Languages and Frameworks: We've placed development languages (such as Scala or Golang) here, as well as more low-level development frameworks (such as Play or Symfony), which are useful - for implementing custom software of all kinds.{" "} + for implementing custom software of all kinds.

  • Tools: Here we put different software tools - from