Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EntityAddToWorld/EntityRemoveFromWorld fired incorrectly in some cases #9581

Open
Boy0000 opened this issue Aug 5, 2023 · 1 comment · May be fixed by #11398
Open

EntityAddToWorld/EntityRemoveFromWorld fired incorrectly in some cases #9581

Boy0000 opened this issue Aug 5, 2023 · 1 comment · May be fixed by #11398
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. status: unlikely Unlikely to ever be worked on due to complexity or risk type: bug Something doesn't work as it was intended to.

Comments

@Boy0000
Copy link
Contributor

Boy0000 commented Aug 5, 2023

Expected behavior

When an entity is added EntityAddToWorld should fire once and EntityRemoveFromWorld should not fire

Observed/Actual behavior

When specific entities are loaded it will first call EntityAddToWorldEvent, then EntityRemoveFromWorldEvent and again EntityAddToWorldEvent for the same entity

Steps/models to reproduce

Easiest way I could reproduce it is simply spawning an entity and rejoining
Summoning it initially has no issues
But when rejoining it triggers the event like shown below

Base.Profile.2023.08.06.-.00.59.56.10.mp4

Plugin and Datapack List

[00:50:29 INFO]: Server Plugins (1):
[00:50:29 INFO]: Paper Plugins:
[00:50:29 INFO]: - untitled1

version
[00:50:31 INFO]: Checking version, please wait...
[00:50:31 INFO]: This server is running Paper version git-Paper-103 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 2c55dd8)
You are running the latest version

Paper version

[00:50:31 INFO]: Checking version, please wait...
[00:50:31 INFO]: This server is running Paper version git-Paper-103 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 2c55dd8)
You are running the latest version

Other

untitled-plugin: image
@Boy0000 Boy0000 added status: needs triage type: bug Something doesn't work as it was intended to. labels Aug 5, 2023
@papermc-projects papermc-projects bot moved this to 🕑 Needs Triage in Issues: Bugs Aug 5, 2023
@Machine-Maker
Copy link
Member

Machine-Maker commented Aug 5, 2023 •
edited
Loading

I can confirm this behavior. I had to restart the server after spawning the entity, but I could the add/remove/add behavior when I joined and caused the chunks to load.

EDIT: I added "unlikely" to this, as fixing it is a larger change that would have other ramifications. I would expect this not to be fixed for a while.

@Machine-Maker Machine-Maker added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. and removed status: needs triage labels Aug 5, 2023
@papermc-projects papermc-projects bot moved this from 🕑 Needs Triage to ✅ Accepted in Issues: Bugs Aug 5, 2023
@Machine-Maker Machine-Maker added the status: unlikely Unlikely to ever be worked on due to complexity or risk label Aug 6, 2023
@jpenilla jpenilla linked a pull request Sep 13, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. status: unlikely Unlikely to ever be worked on due to complexity or risk type: bug Something doesn't work as it was intended to.
Projects
Issues: Bugs
Status: ✅ Accepted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ticket on player join to avoid chunk load-unload-load cycle PaperMC/Paper
2 participants
@Machine-Maker @Boy0000