Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with Name and Lore including multiple space characters #6293

Closed
3 tasks done
muhyomuhyo opened this issue Jul 30, 2021 · 7 comments · Fixed by #8235
Closed
3 tasks done

problem with Name and Lore including multiple space characters #6293

muhyomuhyo opened this issue Jul 30, 2021 · 7 comments · Fixed by #8235
Labels
priority: low This issue only describes a minor inconvenience. type: bug Something doesn't work as it was intended to. version: 1.17 Game version 1.17

Comments

@muhyomuhyo
Copy link

muhyomuhyo commented Jul 30, 2021

issue

Expected behavior

multiple space characters in name and lore are ignored.

before paper #135, it's not happend.

expected behavior

should be..
name: stone axe (with 4 space characters)
lore:
01 (with no space characters)
0 2 (with a space character)
0 3 (with 2 space characters)
0 4 (with 3 space characters)
0 5 (with 4 space characters)
0 6 (with 5 space characters)
0 7 (with 6 space characters)
0 8 (with 7 space characters)
0 9 (with 8 space characters)
0 x (with 9 space characters)

Observed/Actual behavior

current behavior (after #136)
Name: stone axe (with a space character)
01 (with no space characters)
0 2 (with a space character)
0 3 (with a space character)
0 4 (with a space character)
0 5 (with a space character)
0 6 (with a space character)
0 7 (with a space character)
0 8 (with a space character)
0 9 (with a space character)
0 x (with a space character)

This may related with changes "fix empty array elements in command args (fixes #5777) #5778"

Steps/models to reproduce

see picture.

Plugin list

essentials, multiverse, worldGuard, worldEdit, worldborder, shopkeepers, LWCX, CoreProtect

Paper version

Paper version git-Paper-137 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: a67959e)

Agreements

  • I am running the latest version of Paper available from https://papermc.io/downloads.
  • I have searched for and ensured there isn't already an open issue regarding this.
  • My version of Minecraft is supported by Paper.

Other

No response
issue

@kezz
Copy link
Contributor

kezz commented Jul 30, 2021

I get the same result on vanilla. I believe vanilla strips multiples spaces when rendering text.

For example, /give @p stone{display:{Lore:['[{"text":"0 1","italic":false}]','[{"text":"0 2","italic":false}]','[{"text":"0 3","italic":false}]']}} 1 produces single spaces between each of the number pairs.

@muhyomuhyo
Copy link
Author

muhyomuhyo commented Aug 5, 2021

not happened on Vanilla.
This happened on paper console command and happened only after paper 136.
Before paper 135 , nothing happened.

This behavior related with fix #5777

Necessary multiple spaces in Lore and Name are trimmed against will.

@kezz
Copy link
Contributor

kezz commented Aug 6, 2021

I did replicate the space stripping on vanilla with the command above.

@sxphirus
Copy link

sxphirus commented Aug 8, 2021

not reproducible on vanilla
(this issue is exclusive to paper)

Test Command : image (~10 spaces in between hi and hi)

Vanilla Output (this is expected output)
image

Paper-135 Output (the one before the change (this is expected output)
image

Paper-136 Output (the one with the change (this is not expected output)
image

Tested with no plugins on the versions given above

@kezz
Copy link
Contributor

kezz commented Aug 8, 2021

So, is the issue that the Paper server is doing the stripping that the vanilla client does in the console, whereas the vanilla console doesn't do this?

@electronicboy
Copy link
Member

Yes, there was an earlier commit which tried to provide consistency between player and command execution in terms of how args work

@muhyomuhyo
Copy link
Author

so revert #5778 , we can fix this problem?

@e-im e-im added type: bug Something doesn't work as it was intended to. version: 1.17 Game version 1.17 labels Aug 21, 2021
@Owen1212055 Owen1212055 moved this to needs-triage in Issues: Bugs Aug 7, 2022
@Owen1212055 Owen1212055 added the priority: low This issue only describes a minor inconvenience. label Aug 7, 2022
@Owen1212055 Owen1212055 moved this from needs-triage to accepted in Issues: Bugs Aug 7, 2022
@github-project-automation github-project-automation bot moved this from ✅ Accepted to Done in Issues: Bugs May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low This issue only describes a minor inconvenience. type: bug Something doesn't work as it was intended to. version: 1.17 Game version 1.17
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants