Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema.js database agnostic #1468

Merged
merged 2 commits into from
Apr 12, 2016
Merged

Schema.js database agnostic #1468

merged 2 commits into from
Apr 12, 2016

Conversation

flovilmart
Copy link
Contributor

  • Schema.js now handles the Parse Schema format in and out
  • Removes _DONOTUSE functions

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

drew-gross
drew-gross reviewed Apr 12, 2016
View reviewed changes
src/Controllers/DatabaseController.js
if (match) {
return match[1];
if (t.type == 'Relation') {
return t.targetClass;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@codecov-io
Copy link

Current coverage is 92.77%

Merging #1468 into master will decrease coverage by -0.03% as of 73a211b

@@            master   #1468   diff @@
======================================
  Files           87      87       
  Stmts         5479    5483     +4
  Branches      1010    1014     +4
  Methods          0       0       
======================================
+ Hit           5085    5087     +2
  Partial         10      10       
- Missed         384     386     +2

Review entire Coverage Diff as of 73a211b

Powered by Codecov. Updated on successful CI builds.

@drew-gross
Copy link
Contributor

This looks awesome! Feel free to merge right away if you want to do the geopoint thing in another PR.

@flovilmart
Copy link
Contributor Author

I was definitely thinking of doing it separately as our update mechanic is not centralized in the MongoSchemaCollection.js

@flovilmart flovilmart merged commit c050a65 into master Apr 12, 2016
@flovilmart flovilmart deleted the mongo-schema-nits branch April 12, 2016 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@drew-gross drew-gross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flovilmart @facebook-github-bot @codecov-io @drew-gross