Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ConnectionConfiguration public #1470

Open
twenzel opened this issue Oct 21, 2024 · 2 comments · May be fixed by #1471
Open

Make ConnectionConfiguration public #1470

twenzel opened this issue Oct 21, 2024 · 2 comments · May be fixed by #1471
Labels
Improvement

Comments

@twenzel
Copy link

twenzel commented Oct 21, 2024

Describe the suggested improvement

Sometimes you need to deal with the RabbitMQ connection string for other reasons. Therefor you've to parse the connection string and handle the different schemas (amqp or sql-style).

You already have a perfect implementation, the NServiceBus.Transport.RabbitMQ.ConnectionConfiguration.Create method. Unfortunately it cannot be used because the ConnectionConfiguration class is private.

Please make this class public so it can be re-used.

Additional Context

No response
twenzel added a commit to twenzel/NServiceBus.RabbitMQ that referenced this issue Oct 21, 2024
@twenzel
Make ConnectionConfiguration public
890be79 
Fixes Particular#1470
@twenzel twenzel linked a pull request Oct 21, 2024 that will close this issue
Open
@andreasohlund
Copy link
Member

@twenzel thanks for raising this and the corresponding PR, to better evaluate the proposal can you share some details on the use case that requires the connection string to be parsed? This functionality would likely sit better in the RabbitMQ client, have you checked if something similar is available in the RabbitMQ client library?

@twenzel
Copy link
Author

twenzel commented Oct 24, 2024

Unfortunately,I didn't found anything in the RabbitMQ client library.
Use case: I've an connection string (might be amqp or NServiceBus) and want to fill the ConnectionProperties of the RabbitMQ.Client.ConnectionFactory.

This whole story is done to because we want to have 2 different ConnectionStrings. One with administrative permissions and one regular permissions. The "Admin-ConnectionString" is used to create the infrastructure (Exchanges and Queues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make ConnectionConfiguration public twenzel/NServiceBus.RabbitMQ
2 participants
@andreasohlund @twenzel