Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential bugs in LocationService #363

Closed
TruffleClock opened this issue Apr 5, 2020 · 2 comments
Closed

Potential bugs in LocationService #363

TruffleClock opened this issue Apr 5, 2020 · 2 comments
Labels
Bug Something isn't working High Priority High importance / High value

Comments

@TruffleClock
Copy link
Contributor

TruffleClock commented Apr 5, 2020 •
edited
Loading

Issue 1
https://github.com/tripleblindmarket/private-kit/blob/develop/app/services/LocationService.js#L100
Why is it starting another BackgroundGeolocation instance if instanceCount > 1? Why would you want multiple instances?

Issue 2
The following callbacks are duplicated in LocationService:

  • BackgroundGeolocation.on('stop' ...
  • BackgroundGeolocation.on('stationary' ...

Issue 3
Backfill logic isn't documented and doesn't seem to make sense. Why is the prior point being duplicated over and over? I think this is the cause of this issue: #360
@kenpugsley kenpugsley added Bug Something isn't working For next release High Priority High importance / High value labels Apr 6, 2020
@NethravathiPuttraju
Copy link
Contributor

We can work on Fixing this issue..

@E3V3A E3V3A mentioned this issue Apr 6, 2020
Closed
@kenpugsley
Copy link
Collaborator

I think all dealt with in #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working High Priority High importance / High value
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TruffleClock @kenpugsley @NethravathiPuttraju