-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine Share #68
Comments
improved the filename for android, need someone to test, for iOS - will need to do something like https://github.com/react-native-community/react-native-share#share-remote-pdf-file-with-gmail--whatsapp-ios I have made some changes here: https://github.com/tushar-dadlani/private-kit/tree/tdadlani/fix_share_name would love your thoughts before I open a PR |
Looks good based on changes, haven't tested it yet. Can you open a PR @tushar-dadlani ? |
I am breaking this into 3 parts
|
I would recommend avoiding that route if possible because other Apps can pickup for the time it is on disk (making the data non-private in a sense). At the same time I am aware of this issue being the library issue not ours so take your call. |
Export on iOS is still an issue when sent as an attachment on Apps like gmail and whatsapp |
Fixed in #283 |
The basic Share functionality works, but it could use some refinement. Specfically two things:
Here is my location log from Private Kit.
The text was updated successfully, but these errors were encountered: