-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy/Pasting items from the game results in massively bloated stats. #2684
Comments
I can't seem to replicate this (2.3.0) could you try to provide more information and maybe a Pastebin link to a build it occurs on. |
I could reproduce it when copying an item with Ctrl-Alt-C in PoE, as that leverages the new functionality in 3.14 to copy advanced mod descriptions. It seems to be picking up the value range for the stats, the appended digits is approximately the average of its range. Ctrl-C:
Ctrl-Alt-C:
|
Ah. I figured it out. Can probably safely close this issue. Sorry for the confusion! |
Good that you've found the root cause, until advanced mod descriptions are implemented in PoB it's probably best to ensure that your copy shortcut doesn't include advanced mod descriptions. For anyone curious, the reason it's sneakily evaluating as a range is that the parenthesis are detected as a range at: PathOfBuilding/src/Classes/Item.lua Lines 415 to 416 in 793399f
Getting a default range spec of 0.5 at: PathOfBuilding/src/Classes/Item.lua Line 460 in 793399f
Finally having the range spec applied in BuildModList at: PathOfBuilding/src/Classes/Item.lua Lines 1091 to 1106 in 793399f
|
Having similar problems as I also use ctrl for advanced modifications. Is there currently any work on this? A relatively easy workaround would could probably be based on the {}-brackets which are, as far as I know, only used in advanced mod descriptions. If any of them are present the ()-brackets could be skipped or interpreted differently. If no one is working on it I maybe will have a look at it later this week. |
Unfortunately, PoB also uses curly brackets internally to give lines a special designation. I do want to support advanced mod descriptions, and it's probably not worth excluding them unless we're adding support for them at the same time. |
It looks like PoB always places additional info on same line
while the text from game has one
|
For instance a rare body armor with +93 to maximum life ends up with +9395 to maximum life when pasted into PoB. So obviously the various calculations (total life, dps etc) get messed up.
Using 2.3.0. The issue was there even before that version, however.
The text was updated successfully, but these errors were encountered: