Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the debug method to use the log crate, and make it optional #45

Open
Pauan opened this issue Oct 21, 2021 · 3 comments
Open

Change the debug method to use the log crate, and make it optional #45

Pauan opened this issue Oct 21, 2021 · 3 comments
Assignees
@Pauan
Labels
breaking-change

Comments

@Pauan
Copy link
Owner

Pauan commented Oct 21, 2021

No description provided.

@Pauan Pauan self-assigned this Oct 21, 2021
@Pauan
Copy link
Owner Author

Pauan commented Oct 21, 2021

The debug method should also accept a user-provided name so that way multiple different debug calls can be differentiated.

@kellytk
Copy link

kellytk commented Oct 23, 2021

May I ask what the advantage is over https://github.com/tokio-rs/tracing?

@Pauan
Copy link
Owner Author

Pauan commented Oct 23, 2021

The tracing crate works with log, so the only advantage of using tracing is that it allows you to add additional metadata. That isn't necessary in this case, since it's just logging a single value.

@alexisfontaine alexisfontaine mentioned this issue Apr 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pauan Pauan

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pauan @kellytk