Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A sign function for signed types #215

Open
Amxx opened this issue Dec 13, 2023 · 1 comment
Open

A sign function for signed types #215

Amxx opened this issue Dec 13, 2023 · 1 comment
Labels
effort: medium Default level of effort. priority: 3 Nice-to-have. Willing to ship without this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@Amxx
Copy link
Contributor

Amxx commented Dec 13, 2023 •
edited
Loading

Describe the feature you would like

I was wondering, whether [...] should offer a proper signum (sign might be too confusing due to cryptographic functions) function that returns the indication (-1, 0, or 1) of the sign of a 32-byte signed integer. Thoughts?

Additional context

The quote above is from @pcaversaccio

I was thinking that, if this is a math operation that is usefull to some users, it should probably be in PRBMath.
@Amxx Amxx added the feature label Dec 13, 2023
@PaulRBerg
Copy link
Owner

Thanks for the feature request, @Amxx! I will consider it.

@PaulRBerg PaulRBerg added type: feature New feature or request. effort: medium Default level of effort. work: obvious priority: 3 Nice-to-have. Willing to ship without this. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. and removed feature labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Default level of effort. priority: 3 Nice-to-have. Willing to ship without this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amxx @PaulRBerg