Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test "mulDivSigned" #26

Open
PaulRBerg opened this issue May 7, 2021 · 0 comments
Open

Test "mulDivSigned" #26

PaulRBerg opened this issue May 7, 2021 · 0 comments
Labels
effort: epic Multi-stage task that may require multiple PRs. priority: 3 Nice-to-have. Willing to ship without this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Owner

In 351798f, I added a new function mulDivSigned, which is a variant of mulDiv for signed numbers.

It's not used anywhere in PRBMathSD59x18 or PRBMathUD60x18, but it's technically part of the code that gets shipped. We should write tests for it.
@PaulRBerg PaulRBerg changed the title Test "mulDivSigned" [prb-math] Test "mulDivSigned" Sep 29, 2021
@PaulRBerg PaulRBerg changed the title [prb-math] Test "mulDivSigned" Test "mulDivSigned" Oct 20, 2021
@PaulRBerg PaulRBerg added effort: epic Multi-stage task that may require multiple PRs. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. type: test Adding, updating, or removing tests. priority: 3 Nice-to-have. Willing to ship without this. and removed enhancement labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: epic Multi-stage task that may require multiple PRs. priority: 3 Nice-to-have. Willing to ship without this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulRBerg