Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL verification is not done correctly #117

Closed
arekm opened this issue May 3, 2021 · 0 comments
Closed

SSL verification is not done correctly #117

arekm opened this issue May 3, 2021 · 0 comments

Comments

@arekm
Copy link

arekm commented May 3, 2021

In OpenPayU/HttpCurl.php

         curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 2);
         curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);

Peer verification is disabled which is a bit of insane. If curl is built with NSS libraries then setting CURLOPT_SSL_VERIFYPEER to false also disables CURLOPT_SSL_VERIFYHOST which is even worse.

From curl docs https://curl.se/libcurl/c/CURLOPT_SSL_VERIFYHOST.html :

NSS: If CURLOPT_SSL_VERIFYPEER is zero, CURLOPT_SSL_VERIFYHOST is also set to zero and cannot be overridden.

Why ssl verification is done in such insecure way?

@regdos regdos closed this as completed in 40f55a6 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant