Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model2netcdf.ED2() gives incorrect output when PFT is in settings but not in ED output #3068

Closed
Aariq opened this issue Nov 15, 2022 · 1 comment

Comments

@Aariq
Copy link
Collaborator

Aariq commented Nov 15, 2022

Bug Description

This is a weird edge case, but should be handled. I did a run with IED_INIT_MODE=6 where the only pft in the history files was pft 9. In pecan.xml I included PFT 9 and 1. The "-E-" files output by ED2 only have pft 9 in them, but the .nc file output by model2netcdf.ED2() have both pfts and the data are super wonky (e.g. negative ABG).

Expected behavior

Should probably just error ("PFTs found in settings not in output!!"). Possibly this is just a warning and it continues, using only the settings PFT that matches the .h5 files.

@Aariq Aariq self-assigned this Nov 15, 2022
@Aariq Aariq changed the title model2netcdf.ED2() error when PFT is in settings but not in output model2netcdf.ED2() gives weird output when PFT is in settings but not in output Nov 15, 2022
@Aariq Aariq changed the title model2netcdf.ED2() gives weird output when PFT is in settings but not in output model2netcdf.ED2() gives weird output when PFT is in settings but not in ED output Nov 15, 2022
@Aariq Aariq changed the title model2netcdf.ED2() gives weird output when PFT is in settings but not in ED output model2netcdf.ED2() gives incorrect output when PFT is in settings but not in ED output Nov 15, 2022
@Aariq
Copy link
Collaborator Author

Aariq commented Feb 2, 2023

So, turns out this is not a thing you're supposed to do (put PFTs in pecan.xml that are not in chort files.). Closing this for now at least

@Aariq Aariq closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant