Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model2netcdf.ED2() calculations for -E- files are incorrect #3126

Closed
Aariq opened this issue Mar 2, 2023 · 2 comments · Fixed by #3129
Closed

model2netcdf.ED2() calculations for -E- files are incorrect #3126

Aariq opened this issue Mar 2, 2023 · 2 comments · Fixed by #3129

Comments

@Aariq
Copy link
Collaborator

Aariq commented Mar 2, 2023

Bug Description

When I re-wrote code in read_E_files(), I didn't have a full understanding of the .h5 files output by ED2 (also the metadata in those files was wrong). The PFT-level monthly variables output in the .nc files should not be trusted. I know how to do the calculations correctly now (I'm fairly certain), so I'll make a PR shortly.

Screenshots

Here's some comparisons of data calculated (correctly) from the .h5 files vs. what's in the .nc files.
Screenshot 2023-03-02 at 10 36 06 AM
Screenshot 2023-03-02 at 10 45 54 AM

@Aariq
Copy link
Collaborator Author

Aariq commented Mar 2, 2023

Calculations done correctly (I hope) here: https://github.com/cct-datascience/ed2-mandifore/blob/main/R/extract_E_files.R

@Aariq Aariq linked a pull request Mar 6, 2023 that will close this issue
13 tasks
@KristinaRiemer
Copy link
Contributor

Can this be moved to closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants