Skip to content

Latest commit

 

History

History
46 lines (26 loc) · 1.99 KB

CONTRIBUTING.md

File metadata and controls

46 lines (26 loc) · 1.99 KB

All pull requests to the master branch will be closed.

Please submit all pull requests to the develop branch.

Language translations will not be merged without unit tests.

See the British english unit tests for an example.

Submitting Issues

If you are submitting a bug, please create a jsfiddle demonstrating the issue.

Contributing

To contribute, fork the library and install grunt and dependencies.

npm install -g grunt-cli
npm install

You can add tests to the files in /test/moment or add a new test file if you are adding a new feature.

To run the tests, do grunt to run all tests.

To check the filesize, you can use grunt size.

To minify all the files, use grunt release. But please don't include minified files in pull requests. We'll minify them when we release.

If your code passes the unit tests (including the ones you wrote), submit a pull request.

Submitting pull requests

Moment.js now uses git-flow. If you're not familiar with git-flow, please read up on it, you'll be glad you did.

When submitting new features, please create a new feature branch using git flow feature start <name> and submit the pull request to the develop branch.

Pull requests for enhancements for features should be submitted to the develop branch as well.

When submitting a bugfix, please check if there is an existing bugfix branch. If the latest stable version is 1.5.0, the bugfix branch would be hotfix/1.5.1. All pull requests for bug fixes should be on a hotfix branch, unless the bug fix depends on a new feature.

The master branch should always have the latest stable version. When bugfix or minor releases are needed, the develop/hotfix branch will be merged into master and released.