Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic for detecting working on deps with spaces imperfect #394

Open
mohawk2 opened this issue May 16, 2021 · 0 comments
Open

Logic for detecting working on deps with spaces imperfect #394

mohawk2 opened this issue May 16, 2021 · 0 comments

Comments

@mohawk2
Copy link
Member

mohawk2 commented May 16, 2021

The MM_Win32 override of quote_dep correctly knows gmake can work on deps with spaces, so falls back to the MM_Any version. That calls can_dep_space which is overridden in MM_Win32 to return true only if GetShortPathName works. When short pathnames are turned off, this gives a false negative.

A simple fix would be to not try the short pathname if on gmake, but a slightly better solution might be to separate the logic of knowing if can shorten paths, from whether one should even try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant