-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBC: C89 changes break DBI #16207
Comments
From @jkeenanBlead has broken the build for CPAN library DBI. This was first I have reproduced his findings on Linux building with both gcc-7.2 and This is being investigated now on #p5p. mauke diagnoses this as fallout Thank you very much. |
From @jkeenanrunning Mkbootstrap for DBI () |
From @jkeenanSummary of my perl5 (revision 5 version 27 subversion 6) configuration: Characteristics of this binary (from libperl): |
The RT System itself - Status changed from 'new' to 'open' |
@arc - Status changed from 'open' to 'resolved' |
@jkeenan - Status changed from 'resolved' to 'open' |
From @jkeenanOn Sun, 22 Oct 2017 12:11:31 GMT, jkeenan wrote:
As of commit 36a113c, DBI is building and PASSing again in blead. Other CPAN libraries -- e.g., Tk -- may still have breakage. -- |
@arc - Status changed from 'open' to 'resolved' |
From @cpansproutOn Mon, 23 Oct 2017 09:28:04 -0700, arc wrote:
Since the ‘new ticket’ feature seems to have disappeared from RT, I’m going to be naughty and reopen this ticket. I have changed the subject to be more informative. PDL is also affected. The build does not fail, but image2d.t fails like this: t/image2d.t ..................... 1/29 as of this commit: commit 9d82a2b Rely on C89 <stdarg.h> -- Father Chrysostomos |
@cpansprout - Status changed from 'resolved' to 'open' |
From @cpansproutOn Wed, 22 Nov 2017 20:26:01 -0800, sprout wrote:
A quick skim of that commit and a corresponding grep (ack) of the PDL source suggests that we need to restore the I_STDARG symbol: $ ack '\bI_STDARG\b' -- Father Chrysostomos |
From @arcFather Chrysostomos via RT <perlbug-followup@perl.org> wrote:
That symbol was restored by this commit: commit 36a113c Define I_STDARG cpp symbol for XS backcompat While I'm not eager in general to go round defining symbols like this Affected modules include DBI, Tk, and DBD::Unify. So I don't think that's the problem any longer. Do you still have the bisection setup you used to find the PDL -- |
From @jkeenanOn Thu, 23 Nov 2017 12:07:28 GMT, arc wrote:
PDL is indeed failing tests when built against blead (more precisely, commit 8510c6c on Nov 21 -- 2 days ago), but looking at the 'make test' output attached, my hunch is that these various failures have multiple causes. Thank you very much. |
From @jkeenanPERL_DL_NONLAZY=1 "/home/jkeenan/testing/blead/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t Test Summary Report t/bad.t (Wstat: 0 Tests: 82 Failed: 0) ##### Summary of my perl5 (revision 5 version 27 subversion 7) configuration: Characteristics of this binary (from libperl): |
From @jkeenanOn Thu, 23 Nov 2017 13:33:08 GMT, jkeenan wrote:
Please ignore the preceding post. I didn't realize that all the failing tests have been TODOed except for the one which Father C singled out. I apologize for the noise. -- |
From @cpansproutOn Thu, 23 Nov 2017 04:07:28 -0800, arc wrote:
Yes, I am running it now. It may take several hours. FYI, the command I did the previous bisect with was: ../perl.git-copy/Porting/bisect.pl --test-module=PDL --cpan-config-dir=/Users/sprout --start=v5.26.0 --end=v5.27.6 using the --test-module option that I just added. -- Father Chrysostomos |
From @cpansproutOn Thu, 23 Nov 2017 08:45:50 -0800, sprout wrote:
The result: OP_MULTICONCAT, so I am closing this ticket. I have mentioned in ticket #132385 that PDL is affected. -- Father Chrysostomos |
@cpansprout - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#132347 (status was 'resolved')
Searchable as RT132347$
The text was updated successfully, but these errors were encountered: