[PATCH] Update PathTools with File::Path dep #16672
Comments
From @mohawk2This is a bug report for perl from etj@cpan.org, From d873764f60160678d932bda37809c606f59bfdc7 Mon Sep 17 00:00:00 2001 This is needed because Perl 5.8.8 has File::Path 1.08, which only supports dist/PathTools/Makefile.PL | 1 + Inline Patchdiff --git a/dist/PathTools/Makefile.PL b/dist/PathTools/Makefile.PL
index 11e04af523..cb0903688c 100644
--- a/dist/PathTools/Makefile.PL
+++ b/dist/PathTools/Makefile.PL
@@ -36,6 +36,7 @@ WriteMakefile
'PREREQ_PM' => {
'Carp' => '0',
'File::Basename' => '0',
+ 'File::Path' => '2.02', # t/abs2rel.t uses
Flags: Site configuration information for perl 5.26.1: Configured by osboxes at Thu Dec 7 03:08:11 GMT 2017. Summary of my perl5 (revision 5 version 26 subversion 1) configuration: Platform: Locally applied patches: @INC for perl 5.26.1: Environment for perl 5.26.1: |
From @xsawyerxCan you rebase this patch against the latest blead? It doesn't apply cleanly at the moment. Also, if you can attach the patch instead of inlined, it would be easier to apply. Thank you. On Sat, 25 Aug 2018 19:04:14 -0700, etj@cpan.org wrote:
|
|
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Sun, 26 Aug 2018 02:04:14 GMT, etj@cpan.org wrote:
If you're going to insert a dependency on File::Path, please require version 2.15. Earlier versions have had significant security flaws. 2.15 is what we are distributing with perl-5.28. Thank you very much.
-- |
From @xsawyerxOn 08/26/2018 06:45 PM, James E Keenan via RT wrote:
If it's a dependencies solely for the test, we shouldn't add it in the In this case, it seems we can just add it as an optional dependency to Thoughts? |
1 similar comment
From @xsawyerxOn 08/26/2018 06:45 PM, James E Keenan via RT wrote:
If it's a dependencies solely for the test, we shouldn't add it in the In this case, it seems we can just add it as an optional dependency to Thoughts? |
From @mohawk2Also would it be better as a TEST_REQUIRES rather than a PREREQ_PM? (with EUMM version-checking as appropriate) Sorry about the space-mangled and non-attached patch. Had a nightmare getting the report filed at all. Is it deliberate there's no web interface to file Perl bugs, or is it just that I'm dumb and couldn't find it? |
From @haargOn Sun, Aug 26, 2018 at 4:04 AM etj@cpan.org (via RT)
I think a better solution is to just use the older style signature. Alternate patch is attached. |
From @haarg0001-fix-mkpath-call-to-be-compatible-with-older-File-Pat.patchFrom 1f07971186b71bd83633d10392075a30be6d9090 Mon Sep 17 00:00:00 2001
From: Graham Knop <[email protected]>
Date: Mon, 27 Aug 2018 11:12:05 +0200
Subject: [PATCH] fix mkpath call to be compatible with older File::Path
mkpath can be called multiple ways, but most aren't supported by very
old versions of File::Path. A prerequisite could be added on a newer
version of the module that that supports the new call signature, but
this introduces a circular dependency. While theoretically this
dependency should be resolvable, since the File::Spec prereq listed in
File::Path is version 0, some toolchains (in particular older CPAN.pm)
will fail to do so.
There isn't any particular advantage to using the new call signature, so
a simple solution is to adjust the test to use the older style.
---
dist/PathTools/t/abs2rel.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
mode change 100644 => 100755 dist/PathTools/t/abs2rel.t
diff --git a/dist/PathTools/t/abs2rel.t b/dist/PathTools/t/abs2rel.t
old mode 100644
new mode 100755
index b77a1c2715..b813e3d1a6
--- a/dist/PathTools/t/abs2rel.t
+++ b/dist/PathTools/t/abs2rel.t
@@ -25,7 +25,7 @@ sub test_rel2abs {
File::Spec->catdir('first_sub_dir', 'sub_sub_dir'),
'second_sub_dir'
);
- mkpath(@subdirs, { mode => 0711 })
+ mkpath(\@subdirs, 0, 0711)
or die "Unable to mkpath: $!";
open my $OUT2, '>',
--
2.18.0
|
From @xsawyerxDefinitely better than our suggestions. Thank you. I'll apply this today. On 08/27/2018 12:26 PM, Graham Knop wrote:
|
From @jkeenanOn Mon, 27 Aug 2018 10:12:24 GMT, xsawyerx@gmail.com wrote:
Would that resolve https://rt.cpan.org/Ticket/Display.html?id=123210 ? -- |
From @mohawk2On Mon, 27 Aug 2018 03:12:24 -0700, xsawyerx@gmail.com wrote:
I agree this is a better solution! |
From @xsawyerxOn 08/27/2018 12:26 PM, Graham Knop wrote:
Merged. Pushed. |
From @mohawk2On Mon, 27 Aug 2018 13:56:33 -0700, xsawyerx@gmail.com wrote:
Could you indicate when a new CPAN PathTools release is likely? |
From @xsawyerxOn 08/28/2018 12:04 AM, etj@cpan.org via RT wrote:
A few days at the latest. |
1 similar comment
From @xsawyerxOn 08/28/2018 12:04 AM, etj@cpan.org via RT wrote:
A few days at the latest. |
From @xsawyerxOn 08/28/2018 09:01 AM, Sawyer X wrote:
And PathTools 3.75 is out. |
|
@xsawyerx - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.30.0, this and 160 other issues have been Perl 5.30.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
|
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#133476 (status was 'resolved')
Searchable as RT133476$
The text was updated successfully, but these errors were encountered: