Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBC: blead breaks AMALTSEV/Test-Unit-0.27.tar.gz #16956

Closed
p5pRT opened this issue Apr 14, 2019 · 8 comments
Closed

BBC: blead breaks AMALTSEV/Test-Unit-0.27.tar.gz #16956

p5pRT opened this issue Apr 14, 2019 · 8 comments
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)

Comments

@p5pRT
Copy link

p5pRT commented Apr 14, 2019

Migrated from rt.perl.org#134030 (status was 'open')

Searchable as RT134030$

@p5pRT
Copy link
Author

p5pRT commented Apr 14, 2019

From @eserte

The test suite of the (unauthorized) CPAN distribution
AMALTSEV/Test-Unit-0.27.tar.gz is broken since perl 5.29.2.

Sample fail reports on CPAN Testers:

The failing test in verbose mode (the reports do not contain this):

not ok ERROR test_numericness
t/tlib/AssertTest.pm:48 - test_numericness(Class::Inner::__A32)
For string '0xF00', expect f but got t

@p5pRT
Copy link
Author

p5pRT commented Apr 14, 2019

From @jkeenan

1. How would one go about obtaining an unauthorized release? I doubt Porting/bisect.pl would locate it, so we would have great difficulty in bisecting to identify the breaking commit in blead.

2. If it's an unauthorized release, I, for one, would not prioritize analysis of the problem. We have plenty of other things to worry about.

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Apr 14, 2019

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 15, 2019

From @eserte

Dana Sun, 14 Apr 2019 15​:26​:43 -0700, jkeenan reče​:

On Sun, 14 Apr 2019 12​:09​:37 GMT, slaven@​rezic.de wrote​:

This is a bug report for perl from slaven@​rezic.de,
generated with the help of perlbug 1.41 running under perl 5.29.9.

-----------------------------------------------------------------
The test suite of the (unauthorized) CPAN distribution
AMALTSEV/Test-Unit-0.27.tar.gz is broken since perl 5.29.2.

Sample fail reports on CPAN Testers​:
- http​://www.cpantesters.org/cpan/report/649cf574-52ac-11e9-b74b-
c5f737ac362d
- http​://www.cpantesters.org/cpan/report/649cf574-52ac-11e9-b74b-
c5f737ac362d

The failing test in verbose mode (the reports do not contain this)​:

not ok ERROR test_numericness
t/tlib/AssertTest.pm​:48 - test_numericness(Class​::Inner​::__A32)
For string '0xF00', expect f but got t

1. How would one go about obtaining an unauthorized release? I doubt
Porting/bisect.pl would locate it, so we would have great difficulty
in bisecting to identify the breaking commit in blead.

Looking into bisect-runner.pl it looks indeed that the helper script is restricted to the latest official CPAN module (it's using CPAN​::Shell->expand("Module", ...)). Theoretically this could be extended to allow arbitrary CPAN distributions (i.e. using CPAN​::Shell->expand(Distribution => ...), maybe if a slash was encountered in the module name).

2. If it's an unauthorized release, I, for one, would not prioritize
analysis of the problem. We have plenty of other things to worry
about.

The official Test-Unit is broken for a long time (see https://rt.cpan.org/Ticket/Display.html?id=102732 ) --- looking at the diffs it looks like the "capturing" author is just trying to fix the modules's problems with newer perls, but neglected (or was unable) to get co-maint permissions.

Regards,
  Slaven

@toddr toddr added the BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) label Feb 17, 2020
@toddr
Copy link
Member

toddr commented Feb 17, 2020

@eserte What action should be taken here?

@eserte
Copy link
Contributor

eserte commented Feb 17, 2020

We still don't have a bisect result. So maybe best is to do extend bisect-runner.pl as proposed above.

@toddr
Copy link
Member

toddr commented Feb 17, 2020

@ppisar did the work for us! https://rt.cpan.org/Public/Bug/Display.html?id=129738 Given it is reported and later fixed in 5.31, I don't see any further action here.

@toddr toddr closed this as completed Feb 17, 2020
@hvds
Copy link
Contributor

hvds commented Feb 18, 2020

I think this should not be closed yet.

This was an inadvertent side-effect of the work for #8730, which was corrected by #17062 . The latter is now apparently proposed for backporting to maint, which will presumably cause Test-Unit to break again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s)
Projects
None yet
Development

No branches or pull requests

4 participants