Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color palette libraries for config and require 2+ colors #5

Open
julietcohen opened this issue Oct 28, 2022 · 1 comment
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@julietcohen
Copy link
Collaborator

julietcohen commented Oct 28, 2022

  • Python version: 3.10.6
  • Operating System: Ubuntu 18.04.6 LTS

Update color palette libraries

In the configuration file for the PDG workflow, we specify a color palette to apply during the rasterization step. The palettes are from the ColorAide and Colormaps libraries.

Examples of color palettes previously used:
"blue_medb717b"
"RdYlBu"
"RdBu"

These color palettes now return an error. As Robyn suggested, we should update the palette libraries. In the meantime, an example of an acceptable palette is: ["#d9c43f", "#d93fce"]

Require 2+ colors in palette

Additionally, consider returning an error message if the user supplies a palette with only 1 color. For example, "#d93fce". Palettes should be a range of colors to visualize data at each z-level.

Accessibility / Readability

We should consider that the default color palette used is colorblind friendly, or at least we flag or suggest color palettes to users that are colorblind friendly. Also, it would be great to add alt text wherever possible, such as for the plot viewer that we will eventually implement.

@julietcohen julietcohen added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Oct 28, 2022
@westminsterabi
Copy link

I'd like to take this as my first issue, it's low priority but seems like low-hanging fruit :)

@robyngit robyngit added the good first issue Good for newcomers label Jan 23, 2024
@westminsterabi westminsterabi self-assigned this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: In Progress
Status: No status
Status: No status
Development

No branches or pull requests

3 participants