Fixes a panic caused by unwrapping an option #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Sep 14, 2020
| @@ -11,7 +11,7 @@ fn get_metadata_inner<'a>( | |||
| it: impl IntoIterator<Item = &'a syn::Attribute>, | |||
| ) -> Vec<syn::Meta> { | |||
| it.into_iter() | |||
| .map(|attr| attr.parse_meta().unwrap()) | |||
| .filter_map(|attr| attr.parse_meta().ok()) | |||
There was a problem hiding this comment.
AFAICT this is still wrong. This will now silently ignore malformed strum attributes. Instead, you should filter by attr.path.is_ident(ident) and then use parse_meta() without discarding errors (the is_ident check below can then be skipped).
There was a problem hiding this comment.
I can also recommend setting up trybuild to test expected proc-macro errors.
There was a problem hiding this comment.
Happy to take a PR fixing this. Historically strum ignored improperly formatted/tagged attributes. Version 0.19 took some steps in the right direction in terms of failing on bad inputs, but not all of them.
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.