Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] New NotificationPusher version 🎉 #183

Open
Ph3nol opened this issue Jul 2, 2019 · 8 comments
Open

[Project] New NotificationPusher version 🎉 #183

Ph3nol opened this issue Jul 2, 2019 · 8 comments

Comments

@Ph3nol
Copy link
Owner

Ph3nol commented Jul 2, 2019

Hey there,

I plan to develop a new version of NotificationPusher this year, including many new features, and a Dockerized standalone microservice (K8s ready). 🙌🕺
Don't worry, this current version will continue to exist as a legacy version.

This lib has been writen in 2013. 😵
After 1K+ stars on Github and 1M+ installations, it could be great to develop a new opus of it!
Of course, this new version will respect all current PHP standards: DDD & TDD powered!

Some questions for you:

  • What do you think about it?
  • Any ideas or suggestions for this new version?

I take this message to thank all the contributors! THANK YOU, you rocks guys! 💪❤️


Feel free to sponsor this project with clicking the Github "Sponsor" button! 🤩
If this allows, I will push the project further (hosted mode, SaaS service and more).

@Ph3nol Ph3nol changed the title [V3 Project] New NotificationPusher version 🎉 [Project] New NotificationPusher version 🎉 Jul 2, 2019
@Ph3nol Ph3nol self-assigned this Jul 2, 2019
@Ph3nol Ph3nol pinned this issue Jul 2, 2019
@seyfer
Copy link
Collaborator

seyfer commented Oct 13, 2019

@Ph3nol hello, I'm interested to help, maybe.
Sounds very good for me to add some DDD flavor into the code, I like DDD a lot. :)

My question is - why not continue with v3 development with refactoring instead of re-writing from scratch? Have you checked this discussion? :)
#146 (comment)

I had a plan in my head also, to do it gradually into v3:

  • change tests coverage to PhpUnit (since it is a standard in PHP)
  • change implementation for IOS from outdated Zend to suggested lib edamov/pushok with k8 support.
  • refactor and drop support for php5.

Does it make sense or not really? 😄

@seyfer seyfer added the 3.x label Oct 13, 2019
@Ph3nol
Copy link
Owner Author

Ph3nol commented Oct 14, 2019

It definitely makes sense! 😄

@Ph3nol
Copy link
Owner Author

Ph3nol commented Oct 24, 2019

@seyfer I had your e-mail. I'll answer you ASAP! 😉

@wumke
Copy link

wumke commented Dec 13, 2019

  • Symfony 5 is released a couple of weeks ago, so the dependencies on Symfony components should be updated to include Symfony 5 (when I start to migrate my Symfony project I might take a look at this lib and check where compatibility issues occur, if I find some time)
  • I would not drop support for php5 yet... give it another year?

@seyfer
Copy link
Collaborator

seyfer commented May 25, 2020

@wumke I set it to 5 in this PR #195
please review if you have time 🙂

UPD; actually it is not really possible to allow Symfony 5 until we support PHP5.6 because Symfony 5+ requires php7.2 as the minimum version.

UPD2; actually, from Symfony 4+ they bumped minimum PHP version to 7.1. so for this library Symfony 3.4 is maximum, until php5.6 support will be dropped.
Symfony <5 was set here #167, which means it includes 4.0 +, but the build will not pass for php5.6 if composer.lock updated.

@Ph3nol Ph3nol unpinned this issue Mar 30, 2021
@efreed
Copy link

efreed commented Apr 25, 2021

I'm looking for Symfony 5 support, or I will need to stay on Symfony 4 for a while. How did this v3.0 project go? Is there somewhere else to look for this version 3.0?

@seyfer
Copy link
Collaborator

seyfer commented Apr 25, 2021

Nobody ever had time. @efreed open-source runs on contributions. You are welcome to help.
Otherwise, this library declared as deprecated and you are free to use any other.

@efreed
Copy link

efreed commented May 5, 2021

Update: I replaced NotificationPusher in my project with one file per device type that's less than 100 lines.

I'll share them here for anyone interested.
https://gist.github.com/efreed/89b64d4c0c2a760466dca170b11e10eb

I don't have experience making files like this into an official composer dependency, if anyone wants to take the code and make it official, go for it, it's yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants