You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In GCM adapter, in the push function you chunk the tokens per 100. When you iterate over the chunks, you store the response of the client->send() in $this->response, but if someone sends more than 100 tokens you override the response with the new response you receive from the send()!
If for example I send a message to 110 tokens, you will send the first 100 and store the response, but in the next iteration (next 10 tokens) you will override the previous response with the last 10.
Also you should consider changing the chunk value to 1000 (as this the maximum number of allowed tokens in GCM multicast), to improve the performance. Or even better this value should be passed as an optional argument in the push() function of the push manager.
The text was updated successfully, but these errors were encountered:
In GCM adapter, in the push function you chunk the tokens per 100. When you iterate over the chunks, you store the response of the
client->send()
in$this->response
, but if someone sends more than 100 tokens you override the response with the new response you receive from thesend()
!If for example I send a message to 110 tokens, you will send the first 100 and store the response, but in the next iteration (next 10 tokens) you will override the previous response with the last 10.
Also you should consider changing the chunk value to 1000 (as this the maximum number of allowed tokens in GCM multicast), to improve the performance. Or even better this value should be passed as an optional argument in the
push()
function of the push manager.The text was updated successfully, but these errors were encountered: