Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

[Feature Request] Season Management & Restriction #172

Closed
xe1os opened this issue Nov 16, 2019 · 10 comments
Closed

[Feature Request] Season Management & Restriction #172

xe1os opened this issue Nov 16, 2019 · 10 comments
Labels
feature suggestion Something to think about.

Comments

@xe1os
Copy link

xe1os commented Nov 16, 2019

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
It would be better if only the corresponding season is displayed to the user at the time of creating match. Super admins can have the access to create match from any available season.

Describe alternatives you've considered
Super admin to assign or lock seasons for users.

Additional context
It will be easier for the admin to select the only available season instead of selecting from the drop down list.

@xe1os xe1os added the feature suggestion Something to think about. label Nov 16, 2019
@xe1os xe1os changed the title [Feature Request] Seasons not to be displayed to all users during match creation [Feature Request] Season selection to be available only to the creator & Super admin Nov 16, 2019
@PhlexPlexico
Copy link
Owner

I don't exactly see what you mean by corresponding season? You can have multiple seasons running at once, and the owner/admin can change the dates in which they occur.

@PhlexPlexico
Copy link
Owner

PhlexPlexico commented Nov 18, 2019

Unless you mean during the match creation that you can only see the seasons you've created, or super-admins can see all seasons? If so, that's a simple query change within here and you can simply add in an admin check to see if g.user is an admin/super admin and create a different query.

@xe1os
Copy link
Author

xe1os commented Nov 19, 2019

I don't exactly see what you mean by corresponding season? You can have multiple seasons running at once, and the owner/admin can change the dates in which they occur.

I meant during match creation admin should only see the season that was created by him.

@xe1os
Copy link
Author

xe1os commented Nov 19, 2019

Unless you mean during the match creation that you can only see the seasons you've created, or super-admins can see all seasons? If so, that's a simple query change within here and you can simply add in an admin check to see if g.user is an admin/super admin and create a different query.

It would be great if we have an option where super admin assigns the seasons to admins. By doing this we can restrict admin to select only an assigned season at the time of match creation.

@xe1os
Copy link
Author

xe1os commented Nov 19, 2019

This is to avoid admins making mistakes selecting wrong season at the time of match creation and realising it later. This ends up screwing the stats.

@PhlexPlexico
Copy link
Owner

I kinda see what you're getting at here. Allow a superadmin to change ownerships of a season to a user, or admin, and the admin has the same power as a user. The way it's currently implemented is that after assignment the user will still be able to edit the dates though, is that alright?

@xe1os
Copy link
Author

xe1os commented Nov 19, 2019

I kinda see what you're getting at here. Allow a superadmin to change ownerships of a season to a user, or admin, and the admin has the same power as a user. The way it's currently implemented is that after assignment the user will still be able to edit the dates though, is that alright?

Yes. also the user or admin shouldn't be allowed to see or select the other ongoing season from match creation page. Only super admin should have that power.

@xe1os xe1os changed the title [Feature Request] Season selection to be available only to the creator & Super admin [Feature Request] Season Management & Restriction Nov 22, 2019
@PhlexPlexico
Copy link
Owner

I believe there is no reason an admin shouldn't be able to select those seasons, it would make sense since they have elevated privileges over any other user, and should still be able to select.

@xe1os
Copy link
Author

xe1os commented Nov 28, 2019

I believe there is no reason an admin shouldn't be able to select those seasons, it would make sense since they have elevated privileges over any other user, and should still be able to select.

Agreed. but in this case even a user is able to select the other season at the time of match creation page.

@PhlexPlexico
Copy link
Owner

A user is no longer allowed to see seasons that are not owned by them. I can confirm on my with two accounts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature suggestion Something to think about.
Projects
None yet
Development

No branches or pull requests

2 participants