Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/prod/tekton): add tekton results instances #767

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Nov 9, 2023

Signed-off-by: wuhuizuo [email protected]

Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request adds a new feature to the apps/prod/tekton directory that sets up instances for Tekton results. The changes include:

  • Node selector added to scheduler.alpha.kubernetes.io in setup.yaml
  • Tekton results instances added to setup/results directory
  • helm-repo-others.yaml added to the infrastructure/_base/sources directory
  • secret-generator added to the infrastructure/prod directory

There do not appear to be any potential problems with this pull request. However, it may be helpful to add more documentation to the README.md file in the apps/prod/tekton/setup/results directory to make it clear what the Tekton results instances are and how they can be used.

Some suggestions to further improve this pull request are:

  • Add more detailed documentation to the README.md file in the apps/prod/tekton/setup/results directory
  • Consider adding more comments to the YAML files to help other developers understand the code
  • Consider adding tests to ensure the new feature is working as expected

@ti-chi-bot ti-chi-bot bot added env/prod will deploy on the main product cluster size/L labels Nov 9, 2023
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit dfaa2f7 into main Nov 10, 2023
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/add-tekton-results-instances branch November 10, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant