You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
First of all: thanks for this great color picker.
I think there are some potential failures if using it in an sandbox or across an iframe.
Because:
"window" is passed to "ColorPicker", but inside, it uses directly "document"
If we look at the code of jquery, it set "document" with: var document = window.document;
So, "ColorPicker" must also set it from the beginning of the code.
Otherwise, it uses the current "window.document" and not the "document" of the provided "window".
I don't take time to write a test code, I only analyse the code.
Thanks again,
ARuben
The text was updated successfully, but these errors were encountered:
aruben-c
changed the title
potential failures with "document" and "appendTo"
potential failures with "document"
Aug 18, 2016
Hi,
First of all: thanks for this great color picker.
I think there are some potential failures if using it in an sandbox or across an iframe.
Because:
"window" is passed to "ColorPicker", but inside, it uses directly "document"
If we look at the code of jquery, it set "document" with:
var document = window.document;
So, "ColorPicker" must also set it from the beginning of the code.
Otherwise, it uses the current "window.document" and not the "document" of the provided "window".
I don't take time to write a test code, I only analyse the code.
Thanks again,
ARuben
The text was updated successfully, but these errors were encountered: