Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential failures with "document" #48

Open
aruben-c opened this issue Jun 28, 2016 · 0 comments
Open

potential failures with "document" #48

aruben-c opened this issue Jun 28, 2016 · 0 comments

Comments

@aruben-c
Copy link

aruben-c commented Jun 28, 2016

Hi,
First of all: thanks for this great color picker.

I think there are some potential failures if using it in an sandbox or across an iframe.
Because:

"window" is passed to "ColorPicker", but inside, it uses directly "document"
If we look at the code of jquery, it set "document" with:
var document = window.document;
So, "ColorPicker" must also set it from the beginning of the code.
Otherwise, it uses the current "window.document" and not the "document" of the provided "window".

I don't take time to write a test code, I only analyse the code.

Thanks again,
ARuben

@aruben-c aruben-c changed the title potential failures with "document" and "appendTo" potential failures with "document" Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant